]> rtime.felk.cvut.cz Git - can-eth-gw-linux.git/commit
efi_pstore: Remove a logic erasing entries from a write callback to hold multiple...
authorSeiji Aguchi <seiji.aguchi@hds.com>
Wed, 14 Nov 2012 20:26:46 +0000 (20:26 +0000)
committerTony Luck <tony.luck@intel.com>
Tue, 27 Nov 2012 00:02:04 +0000 (16:02 -0800)
commit96480d9c8fcfd7e325e9be6a6c6846689707f8e0
tree5bd027ca5ee3f71a0945add556601dbdf05a20c1
parentdd230fecab5e5833b11941f7f4a5732be78b1975
efi_pstore: Remove a logic erasing entries from a write callback to hold multiple logs

[Issue]

Currently, efi_pstore driver simply overwrites existing panic messages in NVRAM.
So, in the following scenario, we will lose 1st panic messages.

1. kernel panics.
2. efi_pstore is kicked and writes panic messages to NVRAM.
3. system reboots.
4. kernel panics again before a user checks the 1st panic messages in NVRAM.

[Solution]

A reasonable solution to fix the issue is just holding multiple logs without erasing
existing entries.
This patch removes a logic erasing existing entries in a write callback
because the logic is not needed in the write callback to support holding multiple logs.

Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
Acked-by: Mike Waychison <mikew@google.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
drivers/firmware/efivars.c