]> rtime.felk.cvut.cz Git - can-eth-gw-linux.git/commit
ndisc: Fix padding error in link-layer address option.
authorYOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@linux-ipv6.org>
Thu, 13 Dec 2012 04:29:36 +0000 (04:29 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Dec 2012 17:58:11 +0000 (12:58 -0500)
commit7bdc1b4abab3af0a803300f706c9814ef4e20a3e
tree6609b090de8aca06d7fb19c374ee3c90917ccd1c
parent499744209b2cbca66c42119226e5470da3bb7040
ndisc: Fix padding error in link-layer address option.

If a natural number n exists where 2 + data_len <= 8n < 2 + data_len + pad,
post padding is not initialized correctly.

(Un)fortunately, the only type that requires pad is Infiniband,
whose pad is 2 and data_len is 20, and this logical error has not
become obvious, but it is better to fix.

Note that ndisc_opt_addr_space() handles the situation described
above correctly.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ndisc.c