]> rtime.felk.cvut.cz Git - can-eth-gw-linux.git/commit
ARM: OMAP2: UART: fix console UART mismatched runtime PM status
authorKevin Hilman <khilman@ti.com>
Mon, 15 Oct 2012 22:19:34 +0000 (15:19 -0700)
committerKevin Hilman <khilman@ti.com>
Mon, 22 Oct 2012 20:35:17 +0000 (13:35 -0700)
commit44b1d42a60f9daeb0070f7766d11711d1be06a8b
treea1918fb123916e7fe051251776f9c24b12764014
parent856c3c5b28597f70068984d036bcee1d342ddb69
ARM: OMAP2: UART: fix console UART mismatched runtime PM status

The runtime PM framework assumes that the hardware state of devices
when initialized is disabled.  For all omap_devices, we idle/disable
device by default.  However, the console uart uses a "no idle" option
during omap_device init in order to allow earlyprintk usage to work
seamlessly during boot.

Because the hardware is left partially enabled after init (whatever
the bootloader settings were), the omap_device should later be fully
initialized (including mux) and the runtime PM framework should be
told that the device is active, and not disabled so that the hardware
state is in sync with runtime PM state.

To fix, after the device has been created/registered, call
omap_device_enable() to finialize init and use pm_runtime_set_active()
to tell the runtime PM core the device is enabled.

Tested on 2420/n810, 3530/Overo, 3530/Beagle, 3730/OveroSTORM,
3730/Beagle-xM, 4460/PandaES.

Suggested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
arch/arm/mach-omap2/serial.c