]> rtime.felk.cvut.cz Git - can-eth-gw-linux.git/commit
htb: fix two bugs
authorEric Dumazet <edumazet@google.com>
Mon, 5 Nov 2012 16:40:49 +0000 (16:40 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Nov 2012 00:06:29 +0000 (19:06 -0500)
commit196d97f6b1a5d44be17f12e5adba36368915ba52
tree2e512f8271b19ba3d15dcb370ff0015eb110329e
parentbd473da35bc21a0004b8ad35c19e0c8b53b03f36
htb: fix two bugs

Commit 56b765b79e9 (htb: improved accuracy at high rates)
introduced two bugs :

1) one bstats_update() was inadvertently removed from
   htb_dequeue_tree(), breaking statistics/rate estimation.

2) Missing qdisc_put_rtab() calls in htb_change_class(),
   leaking kernel memory, now struct htb_class no longer
   retains pointers to qdisc_rate_table structs.

   Since only rate is used, dont use qdisc_get_rtab() calls
   copying data we ignore anyway.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Vimalkumar <j.vimal@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_htb.c