]> rtime.felk.cvut.cz Git - boost-statechart-viewer.git/blobdiff - src/visualizer.cpp
Add more warnings
[boost-statechart-viewer.git] / src / visualizer.cpp
index 16444149ee5060e811f7491b298d6853ca9607f3..8a4171071aac954950b511078b58ba9a5f536f21 100644 (file)
@@ -61,10 +61,12 @@ namespace Model
     class State : public Context
     {
        string initialInnerState;
+       list<string> defferedEvents;
     public:
        const string name;
        explicit State(string name) : name(name) {}
        void setInitialInnerState(string name) { initialInnerState = name; }
+       void addDeferredEvent(const string &name) { defferedEvents.push_back(name); }
        friend ostream& operator<<(ostream& os, const State& s);
     };
 
@@ -88,12 +90,14 @@ namespace Model
        return 0;
     }
 
-
     ostream& operator<<(ostream& os, const Context& c);
 
     ostream& operator<<(ostream& os, const State& s)
     {
-       os << indent << "" << s.name << "\n";
+       string label = s.name;
+       for (list<string>::const_iterator i = s.defferedEvents.begin(), e = s.defferedEvents.end(); i != e; ++i)
+           label.append("<br />").append(*i).append(" / defer");
+       os << indent << s.name << " [label=<" << label << ">]\n";
        if (s.size()) {
            os << indent << s.name << " -> " << s.initialInnerState << " [style = dashed]\n";
            os << indent << "subgraph cluster_" << s.name << " {\n" << indent_inc;
@@ -154,7 +158,7 @@ namespace Model
 
     class Model : public map<string, Machine>
     {
-       Context unknown;        // For forward-declared state classes
+       Context undefined;      // For forward-declared state classes
     public:
        list< Transition*> transitions;
 
@@ -164,16 +168,16 @@ namespace Model
            return ret.first;
        }
 
-       void addUnknownState(State *m)
+       void addUndefinedState(State *m)
        {
-           unknown[m->name] = m;
+           undefined[m->name] = m;
        }
 
 
        Context *findContext(const string &name)
        {
-           Context::iterator ci = unknown.find(name);
-           if (ci != unknown.end())
+           Context::iterator ci = undefined.find(name);
+           if (ci != undefined.end())
                return ci->second;
            iterator i = find(name), e;
            if (i != end())
@@ -186,12 +190,23 @@ namespace Model
            return 0;
        }
 
-       State *removeFromUnknownContexts(const string &name)
+       State *findState(const string &name)
+       {
+           for (iterator i = begin(), e = end(); i != e; ++i) {
+               Context *c = i->second.findContext(name);
+               if (c)
+                   return static_cast<State*>(c);
+           }
+           return 0;
+       }
+
+
+       State *removeFromUndefinedContexts(const string &name)
        {
-           Context::iterator ci = unknown.find(name);
-           if (ci == unknown.end())
+           Context::iterator ci = undefined.find(name);
+           if (ci == undefined.end())
                return 0;
-           unknown.erase(ci);
+           undefined.erase(ci);
            return ci->second;
        }
 
@@ -234,6 +249,28 @@ public:
     }
 };
 
+class FindTransitVisitor : public RecursiveASTVisitor<FindTransitVisitor>
+{
+    Model::Model &model;
+    const CXXRecordDecl *SrcState;
+    const Type *EventType;
+public:
+    explicit FindTransitVisitor(Model::Model &model, const CXXRecordDecl *SrcState, const Type *EventType)
+       : model(model), SrcState(SrcState), EventType(EventType) {}
+
+    bool VisitMemberExpr(MemberExpr *E) {
+       if (E->getMemberNameInfo().getAsString() != "transit")
+           return true;
+       if (E->hasExplicitTemplateArgs()) {
+           const Type *DstStateType = E->getExplicitTemplateArgs()[0].getArgument().getAsType().getTypePtr();
+           CXXRecordDecl *DstState = DstStateType->getAsCXXRecordDecl();
+           CXXRecordDecl *Event = EventType->getAsCXXRecordDecl();
+           Model::Transition *T = new Model::Transition(SrcState->getName(), DstState->getName(), Event->getName());
+           model.transitions.push_back(T);
+       }
+       return true;
+    }
+};
 
 class Visitor : public RecursiveASTVisitor<Visitor>
 {
@@ -241,7 +278,7 @@ class Visitor : public RecursiveASTVisitor<Visitor>
     Model::Model &model;
     DiagnosticsEngine &Diags;
     unsigned diag_unhandled_reaction_type, diag_unhandled_reaction_decl,
-       diag_found_state, diag_found_statemachine, diag_no_history;
+       diag_found_state, diag_found_statemachine, diag_no_history, diag_warning;
 
 public:
     bool shouldVisitTemplateInstantiations() const { return true; }
@@ -259,10 +296,35 @@ public:
            Diags.getCustomDiagID(DiagnosticsEngine::Error, "Unhandled reaction decl '%0'");
        diag_unhandled_reaction_decl =
            Diags.getCustomDiagID(DiagnosticsEngine::Error, "History is not yet supported");
+       diag_warning =
+           Diags.getCustomDiagID(DiagnosticsEngine::Warning, "'%0' %1");
     }
 
     DiagnosticBuilder Diag(SourceLocation Loc, unsigned DiagID) { return Diags.Report(Loc, DiagID); }
 
+    void HandleCustomReaction(const CXXRecordDecl *SrcState, const Type *EventType)
+    {
+       IdentifierInfo& II = ASTCtx->Idents.get("react");
+       // TODO: Lookup for react even in base classes - probably by using Sema::LookupQualifiedName()
+       for (DeclContext::lookup_const_result ReactRes = SrcState->lookup(DeclarationName(&II));
+            ReactRes.first != ReactRes.second; ++ReactRes.first) {
+           if (CXXMethodDecl *React = dyn_cast<CXXMethodDecl>(*ReactRes.first)) {
+               if (React->getNumParams() >= 1) {
+                   const ParmVarDecl *p = React->getParamDecl(0);
+                   const Type *ParmType = p->getType().getTypePtr();
+                   if (ParmType->isLValueReferenceType())
+                       ParmType = dyn_cast<LValueReferenceType>(ParmType)->getPointeeType().getTypePtr();
+                   if (ParmType == EventType)
+                       FindTransitVisitor(model, SrcState, EventType).TraverseStmt(React->getBody());
+               } else
+                   Diag(React->getLocStart(), diag_warning)
+                       << React << "has not a parameter";
+           } else
+               Diag((*ReactRes.first)->getSourceRange().getBegin(), diag_warning)
+                   << (*ReactRes.first)->getDeclKindName() << "is not supported as react method";
+       }
+    }
+
     void HandleReaction(const Type *T, const SourceLocation Loc, CXXRecordDecl *SrcState)
     {
        // TODO: Improve Loc tracking
@@ -280,16 +342,14 @@ public:
                model.transitions.push_back(T);
            } else if (name == "boost::statechart::custom_reaction") {
                const Type *EventType = TST->getArg(0).getAsType().getTypePtr();
-               CXXRecordDecl *Event = EventType->getAsCXXRecordDecl();
-
-               Model::Transition *T = new Model::Transition(SrcState->getName(), "\"??? custom\"", Event->getName());
-               model.transitions.push_back(T);
+               HandleCustomReaction(SrcState, EventType);
            } else if (name == "boost::statechart::deferral") {
                const Type *EventType = TST->getArg(0).getAsType().getTypePtr();
                CXXRecordDecl *Event = EventType->getAsCXXRecordDecl();
 
-               Model::Transition *T = new Model::Transition(SrcState->getName(), "\"??? deferral\"", Event->getName());
-               model.transitions.push_back(T);
+               Model::State *s = model.findState(SrcState->getName());
+               assert(s);
+               s->addDeferredEvent(Event->getName());
            } else if (name == "boost::mpl::list") {
                for (TemplateSpecializationType::iterator Arg = TST->begin(), End = TST->end(); Arg != End; ++Arg)
                    HandleReaction(Arg->getAsType().getTypePtr(), Loc, SrcState);
@@ -308,22 +368,29 @@ public:
            Diag(Decl->getLocation(), diag_unhandled_reaction_decl) << Decl->getDeclKindName();
     }
 
-    CXXRecordDecl *getTemplateArgDecl(const Type *T, unsigned ArgNum)
+    CXXRecordDecl *getTemplateArgDecl(const Type *T, unsigned ArgNum, const SourceLocation Loc)
     {
        if (const ElaboratedType *ET = dyn_cast<ElaboratedType>(T))
-           return getTemplateArgDecl(ET->getNamedType().getTypePtr(), ArgNum);
+           return getTemplateArgDecl(ET->getNamedType().getTypePtr(), ArgNum, Loc);
        else if (const TemplateSpecializationType *TST = dyn_cast<TemplateSpecializationType>(T)) {
            if (TST->getNumArgs() >= ArgNum+1)
                return TST->getArg(ArgNum).getAsType()->getAsCXXRecordDecl();
-       }
+       } else
+           Diag(Loc, diag_warning) << T->getTypeClassName() << "type as template argument is not supported";
        return 0;
     }
 
+    CXXRecordDecl *getTemplateArgDeclOfBase(const CXXBaseSpecifier *Base, unsigned ArgNum) {
+       return getTemplateArgDecl(Base->getType().getTypePtr(), 1,
+                                 Base->getTypeSourceInfo()->getTypeLoc().getLocStart());
+    }
 
     bool VisitCXXRecordDecl(CXXRecordDecl *Declaration)
     {
        if (!Declaration->isCompleteDefinition())
            return true;
+       if (Declaration->getQualifiedNameAsString() == "boost::statechart::state")
+           return true; // This is an "abstract class" not a real state
 
        MyCXXRecordDecl *RecordDecl = static_cast<MyCXXRecordDecl*>(Declaration);
        const CXXBaseSpecifier *Base;
@@ -336,20 +403,27 @@ public:
            Model::State *state;
            // Either we saw a reference to forward declared state
            // before, or we create a new state.
-           if (!(state = model.removeFromUnknownContexts(name)))
+           if (!(state = model.removeFromUndefinedContexts(name)))
                state = new Model::State(name);
 
-           CXXRecordDecl *Context = getTemplateArgDecl(Base->getType().getTypePtr(), 1);
+           CXXRecordDecl *Context = getTemplateArgDeclOfBase(Base, 1);
            Model::Context *c = model.findContext(Context->getName());
            if (!c) {
                Model::State *s = new Model::State(Context->getName());
-               model.addUnknownState(s);
+               model.addUndefinedState(s);
                c = s;
            }
            c->add(state);
 
-           if (CXXRecordDecl *InnerInitialState = getTemplateArgDecl(Base->getType().getTypePtr(), 2))
-               state->setInitialInnerState(InnerInitialState->getName());
+           if (MyCXXRecordDecl *InnerInitialState =
+               static_cast<MyCXXRecordDecl*>(getTemplateArgDeclOfBase(Base, 2))) {
+               if (InnerInitialState->isDerivedFrom("boost::statechart::simple_state") ||
+                   InnerInitialState->isDerivedFrom("boost::statechart::state_machine"))
+                   state->setInitialInnerState(InnerInitialState->getName());
+               else
+                   Diag(Base->getTypeSourceInfo()->getTypeLoc().getLocStart(), diag_warning)
+                       << InnerInitialState->getQualifiedNameAsString() << " as inner initial state is not supported";
+           }
 
 //         if (CXXRecordDecl *History = getTemplateArgDecl(Base->getType().getTypePtr(), 3))
 //             Diag(History->getLocStart(), diag_no_history);
@@ -365,7 +439,8 @@ public:
            Model::Machine m(RecordDecl->getName());
            Diag(RecordDecl->getLocStart(), diag_found_statemachine) << m.name;
 
-           if (CXXRecordDecl *InitialState = getTemplateArgDecl(Base->getType().getTypePtr(), 1))
+           if (MyCXXRecordDecl *InitialState =
+               static_cast<MyCXXRecordDecl*>(getTemplateArgDeclOfBase(Base, 1)))
                m.setInitialState(InitialState->getName());
            model.add(m);
        }